From: Shlok Kulshreshtha Date: Tue, 14 Jul 2026 12:20:31 GMT Subject: [PATCH v3 0/2] t1100: modernize test script Message-ID: <20260714122033.61947-1-diy2903@gmail.com> In-Reply-To: <20260714071633.35446-1-diy2903@gmail.com> This is v3 of the microproject cleaning up t/t1100-commit-tree-options.sh ("Modernize a test script"). Apologies, v2 crossed with Patrick's review of v1. This v3 folds in his feedback as well. Changes since v2: - Patch 1/2: also drop the extraneous blank line before the "flags and then non flags" test, as Patrick suggested. Changes since v1 (carried over from v2): - Patch 2/2: reword the commit message to use the present tense, as Junio suggested. The patches themselves: 1/2 converts the tests from the old backslash-continued test_expect_success style with space-indented bodies to the modern quoted-body form indented with tabs, and removes an extraneous blank line between two tests. 2/2 moves the here-doc that creates "expected" out of the script's top level and into the existing setup test, so it runs under the protection of the test harness. t1100 continues to pass all 5 tests. Shlok Kulshreshtha (2): t1100: modernize test style t1100: move creation of expected output into setup test t/t1100-commit-tree-options.sh | 58 ++++++++++++++++------------------ 1 file changed, 28 insertions(+), 30 deletions(-) Range-diff against v2: 1: 45f590f110 ! 1: e299f096b9 t1100: modernize test style @@ Commit message body ' + While at it, remove an extraneous blank line between two tests. + This is a style-only change; no test logic is modified. Signed-off-by: Shlok Kulshreshtha @@ t/t1100-commit-tree-options.sh: committer Committer Name 11171 + GIT_COMMITTER_DATE="2005-05-26 23:30" \ + TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null +' -+ + +test_expect_success 'read commit' ' + git cat-file commit $(cat commitid) >commit +' @@ t/t1100-commit-tree-options.sh: committer Committer Name 11171 + test_cmp expected commit +' - test_expect_success 'flags and then non flags' ' + test_tick && 2: 36ea70be9d = 2: 5a54427820 t1100: move creation of expected output into setup test -- 2.52.0