From: Shlok Kulshreshtha Date: Tue, 14 Jul 2026 07:16:31 GMT Subject: [PATCH v2 0/2] t1100: modernize test script Message-ID: <20260714071633.35446-1-diy2903@gmail.com> In-Reply-To: <20260713140142.27898-1-diy2903@gmail.com> This is v2 of the microproject cleaning up t/t1100-commit-tree-options.sh ("Modernize a test script"). Thanks to Junio for reviewing v1. The only change since v1 is in the commit message of patch 2/2: it now uses the present tense ("is created") to describe the current behavior of the script, as suggested. Patch 1/2 is unchanged. 1/2 converts the tests from the old backslash-continued test_expect_success style with space-indented bodies to the modern quoted-body form indented with tabs. 2/2 moves the here-doc that creates "expected" out of the script's top level and into the existing setup test, so it runs under the protection of the test harness. t1100 continues to pass all 5 tests. Shlok Kulshreshtha (2): t1100: modernize test style t1100: move creation of expected output into setup test t/t1100-commit-tree-options.sh | 59 +++++++++++++++++----------------- 1 file changed, 29 insertions(+), 30 deletions(-) Range-diff against v1: 1: 45f590f110 = 1: 45f590f110 t1100: modernize test style 2: f74c71c104 ! 2: 36ea70be9d t1100: move creation of expected output into setup test @@ Metadata ## Commit message ## t1100: move creation of expected output into setup test - The "expected" file was created at the top level of the script, outside + The "expected" file is created at the top-level of the script, outside of any test. Code that runs outside of a test is not protected by the test harness: a failure there is not reported as a test failure and is easy to miss. -- 2.52.0