From: Jeff King Date: Tue, 07 Jul 2026 20:25:41 GMT Subject: Re: [PATCH 1/7] hash: use git_hash_init() consistently Message-ID: <20260707202541.GE11780@coredump.intra.peff.net> In-Reply-To: On Tue, Jul 07, 2026 at 01:17:49PM -0700, Junio C Hamano wrote: > > I had actually removed them, but either I missed these two, or more > > likely I ended up re-applying the semantic patch a final time before > > committing (I did a lot of "reset --hard; make hash.cocci.patch && git > > apply hash.cocci.patch" while testing various refactors of the patch > > itself). > > > > I'll drop them in v2. Thanks for reading carefully. > > Thanks. > > If we run cocci twice, the second time it should be idempotent, > right? So running it once, fixing these braces and then running it > again would not make us see the extra braces in the result, I guess. Yep, exactly. If my "re-applying" theory above is correct, that is different because I was calling "reset --hard" in the middle to test that the patch still did what it claimed. ;) I assume this is coccinelle having some kind of "add braces to be careful in some situations" logic, but I didn't dig into it further. -Peff