From: Patrick Steinhardt Date: Mon, 06 Jul 2026 06:24:02 GMT Subject: [PATCH v3 7/9] t: use `test_bool_env` to parse GIT_TEST_LONG Message-ID: <20260706-b4-pks-t-fixes-for-GIT-TEST-LONG-v3-7-4f6c5a37fd1f@pks.im> In-Reply-To: <20260706-b4-pks-t-fixes-for-GIT-TEST-LONG-v3-0-4f6c5a37fd1f@pks.im> It's currently hard to explicitly disable GIT_TEST_LONG by setting it to `false`. Fix this by using `test_bool_env` instead. Signed-off-by: Patrick Steinhardt --- ci/lib.sh | 2 +- t/test-lib.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ci/lib.sh b/ci/lib.sh index b939110a6e..01a0bc6b75 100755 --- a/ci/lib.sh +++ b/ci/lib.sh @@ -321,7 +321,7 @@ export SKIP_DASHED_BUILT_INS=YesPlease # enable the long tests for pushes to the integration branches as well. case "$GITHUB_EVENT_NAME,$CI_BRANCH" in pull_request,*|push,*next*|push,*master*|push,*main*|push,*maint*) - export GIT_TEST_LONG=YesPlease + export GIT_TEST_LONG=true ;; esac diff --git a/t/test-lib.sh b/t/test-lib.sh index ceefb99bff..623fcfb747 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -210,7 +210,7 @@ parse_option () { -i|--i|--im|--imm|--imme|--immed|--immedi|--immedia|--immediat|--immediate) immediate=t ;; -l|--l|--lo|--lon|--long|--long-|--long-t|--long-te|--long-tes|--long-test|--long-tests) - GIT_TEST_LONG=t; export GIT_TEST_LONG ;; + GIT_TEST_LONG=true; export GIT_TEST_LONG ;; -r) mark_option_requires_arg "$opt" run_list ;; @@ -1849,7 +1849,7 @@ test_lazy_prereq AUTOIDENT ' ' test_lazy_prereq EXPENSIVE ' - test -n "$GIT_TEST_LONG" + test_bool_env GIT_TEST_LONG false ' test_lazy_prereq EXPENSIVE_ON_WINDOWS ' -- 2.55.0.795.g602f6c329a.dirty