From: Tian Yuchen Date: Fri, 26 Jun 2026 07:50:35 GMT Subject: [PATCH v2 0/2] environment: move excludes_file into repo_config_values Message-ID: <20260626075037.532164-1-cat@malon.dev> This series continues the libification effort by migrating the global string variable 'excludes_file' into 'struct repo_config_values'. Since this is a dynamically allocated variable, the migration requires proper heap memory management. The series is structured in two commits: - Abstract the XDG fallback lazy-loading logic out of dir.c into a proper getter. - Move the variables into the struct and introduce 'repo_config_values_clear()'. Note on Submodules: A temporary shield 'if (repo != the_repository)' is included in both the getter and the clear function. This prevents uninitialized submodules from triggering the BUG() assertion. (Inspiration: [1]) Changes since V1: - fix a typo in the second commit. - initialize excludes_file to NULL in repo_config_values_init(). - call FREE_AND_NULL() to free attributes_file as well in repo_config_values_clear(). Thanks! Mentored-by: Christian Couder Mentored-by: Ayush Chandekar Mentored-by: Olamide Caleb Bello Signed-off-by: Tian Yuchen [1] https://lore.kernel.org/git/c95a7730-7b14-4be0-a4e4-861b2f5430ea@gmail.com/ Tian Yuchen (2): dir: encapsulate excludes_file lazy-load environment: move excludes_file into repo_config_values dir.c | 4 ++-- environment.c | 32 +++++++++++++++++++++++++++++--- environment.h | 13 ++++++++++++- repository.c | 1 + 4 files changed, 44 insertions(+), 6 deletions(-) -- 2.43.0