From: Pablo Sabater Date: Fri, 19 Jun 2026 14:56:31 GMT Subject: [PATCH GSoC RFC v13 02/12] git-compat-util: add strtoul_ul() with error handling Message-ID: <20260619-ps-eric-work-rebase-v13-2-3d4c7315d2f8@gmail.com> In-Reply-To: <20260619-ps-eric-work-rebase-v13-0-3d4c7315d2f8@gmail.com> From: Eric Ju We already have strtoul_ui() and similar functions that provide proper error handling using strtoul from the standard library. However, there isn't currently a variant that returns an unsigned long. This variant is needed in a subsequent commit. This variant is needed in a subsequent commit to enable returning an unsigned long with proper error handling. Signed-off-by: Pablo Sabater --- git-compat-util.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/git-compat-util.h b/git-compat-util.h index 8809776407..4bf569f35c 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -975,6 +975,26 @@ static inline int strtoul_ui(char const *s, int base, unsigned int *result) return 0; } +/* + * Convert a string to an unsigned long using the standard library's strtoul, + * with additional error handling to ensure robustness. + */ +static inline int strtoul_ul(char const *s, int base, unsigned long *result) +{ + unsigned long ul; + char *p; + + errno = 0; + /* negative values would be accepted by strtoul */ + if (strchr(s, '-')) + return -1; + ul = strtoul(s, &p, base); + if (errno || *p || p == s) + return -1; + *result = ul; + return 0; +} + static inline int strtol_i(char const *s, int base, int *result) { long ul; -- 2.54.0