From: Jeff King <peff@peff.net>
Date: Thu, 18 Jun 2026 23:35:36 GMT
Subject: Re: git-2.55.0-rc1 t4216 broken TAP failures on non-x86 arch
Message-ID: <20260618233536.GA1431359@coredump.intra.peff.net>
In-Reply-To: <xmqq4iizpkig.fsf@gitster.g>

On Thu, Jun 18, 2026 at 03:10:47PM -0700, Junio C Hamano wrote:

> Patrick Steinhardt <ps@pks.im> writes:
> 
> >> Building git-2.55.0-rc1 today, all non-x86 architectures
> >> failed with:
> >>  ...
> >> This looks like it comes from the following chunk of code in
> >> the test:
> >> 
> >>     # expect will not match actual if char is unsigned by default. Write the test
> >>     # in this way, so that a user running this test script can still see if the two
> >>     # files match. (It will appear as an ordinary success if they match, and a skip
> >>     # if not.)
> >>     if test_cmp highbit1/expect highbit1/actual
> >>     then
> >> 	    test_set_prereq SIGNED_CHAR_BY_DEFAULT
> >>     fi
> >>     test_expect_success SIGNED_CHAR_BY_DEFAULT 'check value of version 1 changed-path' '
> >> 	    # Only the prereq matters for this test.
> >> 	    true
> >>     '
> 
> The "problematic" part is from mid 2024, so it is not anything new
> in 2.55-rc1, is it?  Nobody built and ran tests for the past two
> years on non-x86 boxes?

Presumably they did not notice the extra cruft to stdout, either because
it was being eaten by the TAP harness or for a raw "make test" it was
mixed in with a million other lines of output. But since 389c83025d (t:
let prove fail when parsing invalid TAP output, 2026-06-04) it will
cause a test failure.

-Peff