From: Jeff King <peff@peff.net>
Date: Thu, 11 Jun 2026 08:33:20 GMT
Subject: Re: [PATCH v3] transport-helper: fix TSAN race in transfer_debug()
Message-ID: <20260611083320.GI2191159@coredump.intra.peff.net>
In-Reply-To: <20260609134741.4727-2-pushkarkumarsingh1970@gmail.com>

On Tue, Jun 09, 2026 at 01:47:42PM +0000, Pushkar Singh wrote:

> Changes since v2:
> - Treat an uninitialized transfer_debug_enabled as a BUG()
>   instead of silently treating it as disabled.
> - Follow Jeff King's suggestion to distinguish an
>   uninitialized state from a disabled state.

Thanks, this looks OK to me.

> +	if (transfer_debug_enabled < 0)
> +		BUG("somebody forgot to check GIT_TRANSLOOP_DEBUG!");

That is a somewhat silly message, but the point is that nobody is
supposed to see it ever. And it does lead them to roughly the right
spot, so I think it's sufficient. (Yes, I know it came from my earlier
response).

-Peff