From: Jeff King Date: Mon, 08 Jun 2026 22:51:49 GMT Subject: Re: [PATCH 0/3] config: allow disabling config includes Message-ID: <20260608225149.GB340696@coredump.intra.peff.net> In-Reply-To: On Mon, Jun 08, 2026 at 01:57:03PM +0000, Derrick Stolee via GitGitGadget wrote: > This series introduces a new way to ignore config include directives via two > mechanisms: > > * GIT_CONFIG_INCLUDES=0 in the environment. > * git --no-includes ... in the command line. > > My motivation is from a tricky situation where users want to do the risky > thing and include a repo-tracked file for sharing aliases and other > recommended config. They are then struggling in a later build step that is > running Git commands (under a tool we don't control and can't change) that > then cause filesystem accesses outside of the build system's sandbox. I'm not opposed to global control of includes, but this is just one way in which config can escape the sandbox. They can always point to files (e.g., core.attributesFile) or even commands that totally leave the sandbox (e.g., ext diff or textconv commands). Fundamentally git config is equivalent to arbitrary code execution, so pointing an include at a repo-tracked file carries the risk of confusion both malicious and accidental. So I dunno. From the described motivation, this feels like a band-aid that fixes only one narrow instance of a greater problem. The notion of enabling/disabling includes per-command is itself a flexible building block. So it's possible that it has other uses in general. But it's also a fairly broad hammer that covers more than your use case. If you're planning to use "git --no-includes" in some script, then it breaks the config of anybody who uses includes in their user-level ~/.gitconfig file. So you may need some more directed limiting. > One thing I do worry about is whether or not this would cause a significant > break in behavior, or if this is a relatively safe thing to allow. Yeah. Consider something like: $ cat ~/.gitconfig [user] name = My Name email = me@personal.example.com [includeIf "gitdir:/path/to/work/stuff"] path = .gitconfig-work $ cat ~/.gitconfig-work [user] email = me@work.example.com Using "git --no-include" will silently use the wrong user.email value. That's OK if the user is asking for it, but if you are planning to sprinkle "--no-include" inside scripts, that's likely to cause confusion. -Peff