From: Tian Yuchen Date: Sat, 30 May 2026 16:05:15 GMT Subject: [PATCH v1 0/4] environment.c: migrate 'trust_executable_bit' into 'repo_config_values' Message-ID: <20260530160520.77859-1-cat@malon.dev> The 'core.filemode' configuration, which is stored as a global variable 'trust_executable_bit', is a core filesystem capability flag. Move it into 'repo_config_values' to tie it to the specific repository instance it was read from. Eager parsing is maintained because this flag is heavily consulted in hot paths. To avoid falling back to 'the_repository', refactor the signatures of helper functions: - ce_mode_from_stat() - st_mode_from_ce() - fake_lstat() - check_removed() These functions now accept a 'struct index_state *istate', ensuring the correct context is seamlessly passed down to the lowest levels. Note: 'repo_config_values()' still does not support any 'struct repository' other than 'the_repository'. In other words, this series of patches is laying the groundwork for the eventual elimination of 'the_repository'. Previous related work: - [PATCH 2/6] config: add trust_executable_bit to global config - [PATCH] Refactor 'trust_executable_bit' to repository-scoped setting (This series of patches was unsuccessful because the target location selected was 'struct repo_settings', which our analysis indicated was not the optimal choice. For further details, please see: [1]) [1] https://lore.kernel.org/git/837b5360b40f992351f489a0ae05fedf49884c6e.1685716420.git.gitgitgadget@gmail.com/ [2] https://lore.kernel.org/git/20260301190017.53539-1-dronarajgyawali@gmail.com/ [3] https://lore.kernel.org/git/xmqq1pht6nyx.fsf@gitster.g/ Mentored-by: Christian Couder Mentored-by: Ayush Chandekar Mentored-by: Olamide Caleb Bello Signed-off-by: Tian Yuchen Tian Yuchen (4): read-cache: remove redundant extern declarations read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' environment: move 'trust_executable_bit' into repo_config_values read-cache: pass 'istate' to stat/mode helper functions apply.c | 6 ++++-- builtin/update-index.c | 2 +- diff-lib.c | 20 +++++++++--------- environment.c | 4 ++-- environment.h | 2 +- read-cache-ll.h | 2 +- read-cache.c | 47 ++++++++++++++++++++++++++++++++---------- read-cache.h | 17 +++------------ 8 files changed, 58 insertions(+), 42 deletions(-) -- 2.43.0