From: Jeff King Date: Wed, 13 May 2026 18:58:25 GMT Subject: Re: [PATCH] http: handle absolute-path alternates from server root Message-ID: <20260513185825.GB147423@coredump.intra.peff.net> In-Reply-To: On Wed, May 13, 2026 at 10:10:54AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > ... Probably in a way that makes it totally invalid, but > > if you were very unlucky you could turn something like: > > > > http://victim.com.evil.domain:8000 > > > > into: > > > > http://victim.com > > > > Which looks like the start of a redirect attack, except that > > the attacker could just have written "http://victim.com" in > > the first place! Either way we feed it to > > is_alternate_allowed(), which is where we check redirect and > > protocol rules. > > Yuck. I know I am the guilty party who introduced the dumb HTTP > walker but I wish we could kill it off after all these years. I did > not even recall that we supported the alternate object store in the > "protocol" until I saw this patch X-<. Me too. It's been the source of many obscure bugs, and I think a couple of vulnerabilities (even though clients never intend to use dumb clones in the first place). We talked about dropping it a few years ago, but Eric countered that dumb clones are easier on the server in some cases (like gigantic public-inbox repos that are packed to keep most of the old history in one big pack that is never updated). The verbatim pack-reuse feature tries to get smart clones closer to that, but it's hard to beat serving a static file from the server's perspective. I haven't measured anything in that area in a while, though. -Peff