From: Jeff King Date: Wed, 29 Apr 2026 08:10:17 GMT Subject: Re: [PATCH v2 14/16] repack: implement incremental MIDX repacking Message-ID: <20260429081017.GB1269182@coredump.intra.peff.net> In-Reply-To: <93e152fb6aa3bbd450d46c6cdd219dfef14d41fc.1776803827.git.me@ttaylorr.com> On Tue, Apr 21, 2026 at 04:37:54PM -0400, Taylor Blau wrote: > Unlike the default mode which writes a single flat MIDX, the incremental > mode constructs a compaction plan that determines which MIDX layers to > write, compact, or copy, and then executes each step using `git > multi-pack-index` subcommands with the --checksum-only flag. This should be --no-write-chain-file, I think. Ditto here: > After writing the new layer, the strategy is evaluated among the > existing MIDX layers in order from oldest to newest. Each step that > writes a new MIDX layer uses "--checksum-only" to avoid updating the > multi-pack-index-chain file. After all steps are complete, the new chain > file is written and then atomically moved into place. In the code I think it is all good, though: > + strvec_pushl(&cmd.args, "--incremental", "--no-write-chain-file", NULL); -Peff