From: Jeff King <peff@peff.net>
Date: Tue, 14 Apr 2026 22:13:35 GMT
Subject: Re: [PATCH v14 12/13] fsmonitor: add tests for Linux
Message-ID: <20260414221335.GA3483791@coredump.intra.peff.net>
In-Reply-To: <xmqq5x5t9sxl.fsf@gitster.g>

On Tue, Apr 14, 2026 at 01:40:38PM -0700, Junio C Hamano wrote:

> diff --git c/t/t7527-builtin-fsmonitor.sh w/t/t7527-builtin-fsmonitor.sh
> index 774da5ac60..dfa06395f6 100755
> --- c/t/t7527-builtin-fsmonitor.sh
> +++ w/t/t7527-builtin-fsmonitor.sh
> @@ -60,8 +60,7 @@ fi
>  
>  stop_daemon_delete_repo () {
>  	r=$1 &&
> -	test_might_fail maybe_timeout 30 \
> -		git -C $r fsmonitor--daemon stop 2>/dev/null
> +	maybe_timeout 30 git -C $r fsmonitor--daemon stop || : &&
>  	rm -rf $1
>  }

Do we need to put it in curly braces to avoid interfering with the &&
chain? Otherwise a failure of anything before the maybe_timeout will hit
the "||".

I guess in this case it is just "r=$1", which will never fail, but it
feels like we should model best practice.

-Peff