From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Fri, 10 Apr 2026 19:18:40 GMT
Subject: Re: [PATCH] checkout: add --autostash option for branch switching
Message-ID: <20260410191840.38747-1-haraldnordgren@gmail.com>
In-Reply-To: <0d1c7bf2-6404-4779-a0d6-6db592510a04@gmail.com>

> This patch seems to be missing the implementation of these new options. 
> Before submitting a patch series I find it is very helpful to run
> 
>      git rebase --keep-base -x make -x 'cd t && prove -j6 <tests that I 
> think might fail>'
> 
> to catch any mistakes.

Wow, that command is so powerful! Thanks for sharing that!

Will shift that definition to an earlier commit in my set.

> Why do we need to create a new repository just to stash some changes?

Isn't it good to do it in isolation, for when the test and/or its cleanup
fails. I tried to change it now, but it's not trivial, I quickly broke a
lot of subsequent tests.

> We have a helper test_commit() for creating commits (it is documented in 
> t/test-lib-functions.sh)

Thanks, will update!


Harald