From: Jeff King <peff@peff.net>
Date: Thu, 09 Apr 2026 20:33:38 GMT
Subject: Re: Git 2.54.0-rc1, subtests of t5310, t5326, t5327
Message-ID: <20260409203338.GB3076846@coredump.intra.peff.net>
In-Reply-To: <021a01dcc827$4e6342c0$eb29c840$@nexbridge.com>

On Thu, Apr 09, 2026 at 09:46:39AM -0400, rsbecker@nexbridge.com wrote:

> >--- a/git-compat-util.h
> >+++ b/git-compat-util.h
> >@@ -690,14 +690,8 @@ static inline uint64_t u64_add(uint64_t a, uint64_t b)
> >  * to override this, if the definition of SSIZE_MAX given by the platform
> >  * is broken.
> >  */
> >-#ifndef MAX_IO_SIZE
> >-# define MAX_IO_SIZE_DEFAULT (8*1024*1024) -# if defined(SSIZE_MAX) &&
> >(SSIZE_MAX < MAX_IO_SIZE_DEFAULT) -#  define MAX_IO_SIZE SSIZE_MAX -# else
> -
> >#  define MAX_IO_SIZE MAX_IO_SIZE_DEFAULT -# endif -#endif
> >+#undef MAX_IO_SIZE
> >+#define MAX_IO_SIZE 128
> [...]
> Please do not make the change in git-compat-util. This will break xwrite().
> We already have MAX_IO_SIZE working and verified from years ago. Changing
> that will remove our platform from being supportable.

I think that was just there to demonstrate that the patch works
regardless of the size, and would not be included in the final.
Building with:

  make CFLAGS=-DMAX_IO_SIZE=128

is probably a nicer way of doing that, though. ;)

-Peff