From: Jeff King Date: Thu, 02 Apr 2026 04:14:58 GMT Subject: [PATCH v2 04/12] pager: explicitly cast away strchr() constness Message-ID: <20260402041458.GD3501239@coredump.intra.peff.net> In-Reply-To: <20260402041433.GA3501120@coredump.intra.peff.net> When we do: char *cp = strchr(argv[i], '='); it implicitly removes the constness from argv[i]. We need "cp" to remain writable (since we overwrite it with a NUL). In theory we should be able to drop the const from argv[i], because it is a sub-pointer into our duplicated pager_env variable. But we get it from split_cmdline(), which uses the traditional "const char **" type for argv. This is overly limiting, but changing it would be awkward for all the other callers of split_cmdline(). Let's do an explicit cast with a note about why it is OK. This is enough to silence compiler warnings about the implicit const problems. Signed-off-by: Jeff King --- pager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pager.c b/pager.c index 5531fff50e..35b210e048 100644 --- a/pager.c +++ b/pager.c @@ -108,10 +108,11 @@ const char *git_pager(struct repository *r, int stdout_is_tty) static void setup_pager_env(struct strvec *env) { - const char **argv; + char **argv; int i; char *pager_env = xstrdup(PAGER_ENV); - int n = split_cmdline(pager_env, &argv); + /* split_cmdline splits in place, so we know the result is writable */ + int n = split_cmdline(pager_env, (const char ***)&argv); if (n < 0) die("malformed build-time PAGER_ENV: %s", -- 2.53.0.1172.ge9e20b5838