From: Jeff King Date: Tue, 31 Mar 2026 23:56:37 GMT Subject: Re: [PATCH 07/12] pseudo-merge: fix disk reads from find_pseudo_merge() Message-ID: <20260331235637.GA2328851@coredump.intra.peff.net> In-Reply-To: <20260331234622.GG2328529@coredump.intra.peff.net> On Tue, Mar 31, 2026 at 07:46:23PM -0400, Jeff King wrote: > So I think there is something wrong or missing from the test setup, and > this bears further investigation. Sadly the answer to the second part > ("does it work now") is still "no idea". I _think_ this takes us in a > positive direction, but my goal here is mainly to quiet the compiler > warning. Further bug-hunting on this experimental feature can be done > separately. If this is the wrong direction or if we just want to keep things minimal in this patch series, the absolute smallest fix is probably to cast away the constness explicitly in find_pseudo_merge(), along with a comment that the fix is almost certainly wrong. ;) -Peff