From: Patrick Steinhardt Date: Tue, 31 Mar 2026 11:26:48 GMT Subject: [PATCH 2/6] reftable/stack: don't call fsync(3p) unless provided Message-ID: <20260331-pks-reftable-portability-fixes-v1-2-46bfae55c68c@pks.im> In-Reply-To: <20260331-pks-reftable-portability-fixes-v1-0-46bfae55c68c@pks.im> Users of the reftable library are expected to provide their own function callback in cases they want to sync(3p) data to disk via the reftable write options. But if no such function was provided we end up calling fsync(3p) directly, which may not even be available on some systems. Drop the call to fsync(3p) and rely on the callback function exclusively. Signed-off-by: Patrick Steinhardt --- reftable/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reftable/stack.c b/reftable/stack.c index 1c9f21dfe1..f9ae832e3a 100644 --- a/reftable/stack.c +++ b/reftable/stack.c @@ -33,7 +33,7 @@ static int stack_fsync(const struct reftable_write_options *opts, int fd) { if (opts->fsync) return opts->fsync(fd); - return fsync(fd); + return 0; } static ssize_t reftable_write_data(int fd, const void *data, size_t size) -- 2.53.0.1185.g05d4b7b318.dirty