From: Jeff King Date: Thu, 26 Mar 2026 17:29:20 GMT Subject: Re: [PATCH 01/11] test-lib: catch misspelt 'test_expect_successo' Message-ID: <20260326172920.GA2447148@coredump.intra.peff.net> In-Reply-To: On Thu, Mar 26, 2026 at 07:27:44AM -0700, Junio C Hamano wrote: > > test_expect_success !MINGW 'a constipated git dies with SIGPIPE' ' > > - OUT=$( ((large_git; echo $? 1>&3) | :) 3>&1 ) && > > + OUT=$( ((large_git || echo $? 1>&3) | :) 3>&1 ) && > > test_match_signal 13 "$OUT" > > ' > > > > > > That neglects to echo $? when large_git surprisingly succeeds, but that > > would mean $OUT is empty, which would cause the test to (correctly) > > fail. I kind of hate it, though. > > Would > > OUT=$( ((large_git && echo 0 || echo $? 1>&3) | :) 3>&1 ) > > do a bit better? Yeah, that is better (though in practice the same for our purposes in this particular test). > We can keep fixing things one by one as we find these little > glitches and gochas, of it may be a whack-a-mole exercise that > eventually will turn out to be futile. I dunno. Yeah, after getting the tests passing locally I pushed to CI and saw a ton of failures. I think one is just: diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh index 630a47af21..7f920d7b9e 100755 --- a/t/t1301-shared-repo.sh +++ b/t/t1301-shared-repo.sh @@ -12,7 +12,7 @@ TEST_CREATE_REPO_NO_TEMPLATE=1 . ./test-lib.sh # Remove a default ACL from the test dir if possible. -setfacl -k . 2>/dev/null +setfacl -k . 2>/dev/null || true # User must have read permissions to the repo -> failure on --shared=0400 test_expect_success 'shared = 0400 (faulty permission u-w)' ' and another seems to involve test_done barfing when no tests have been run (e.g., if we hit a skip_all case). I didn't investigate further. -Peff