From: Adrian Ratiu Date: Thu, 26 Mar 2026 10:18:08 GMT Subject: [PATCH v5 01/12] repository: fix repo_init() memleak due to missing _clear() Message-ID: <20260326101819.1307742-2-adrian.ratiu@collabora.com> In-Reply-To: <20260326101819.1307742-1-adrian.ratiu@collabora.com> There is an old pre-existing memory leak in repo_init() due to failing to call clear_repository_format() in the error case. It went undetected because a specific bug is required to trigger it: enable a v1 extension in a repository with format v0. Obviously this can only happen in a development environment, so it does not trigger in normal usage, however the memleak is real and needs fixing. Fix it by also calling clear_repository_format() in the error case. Signed-off-by: Adrian Ratiu --- repository.c | 1 + 1 file changed, 1 insertion(+) diff --git a/repository.c b/repository.c index 0b8f7ec200..fb4356ca55 100644 --- a/repository.c +++ b/repository.c @@ -322,6 +322,7 @@ int repo_init(struct repository *repo, return 0; error: + clear_repository_format(&format); repo_clear(repo); return -1; } -- 2.52.0.732.gb351b5166d.dirty