From: Jeff King <peff@peff.net>
Date: Wed, 11 Mar 2026 17:48:16 GMT
Subject: Re: [PATCH v3 2/2] list-objects-filter-options: avoid strbuf_split_str()
Message-ID: <20260311174816.GB1900488@coredump.intra.peff.net>
In-Reply-To: <20260311173336.8395-3-deveshigurgaon@gmail.com>

On Wed, Mar 11, 2026 at 05:33:36PM +0000, Deveshi Dwivedi wrote:

> +	while (*p && !result) {
> +		const char *end = strchrnul(p, '+');
> +
> +		strbuf_reset(&sub);
> +		strbuf_add(&sub, p, end - p);
> +
> +		if (sub.len)
> +			result = parse_combine_subfilter(filter_options, sub.buf, errbuf);
> +
> +		if (!*end)
> +			break;
> +		p = end + 1;
>  	}
> +	strbuf_release(&sub);

This version of the loop looks good to me.

-Peff