From: K Jayatheerth Date: Tue, 10 Mar 2026 13:08:19 GMT Subject: Re: [PATCH 0/2] repo: remove redundant variable shadow in stats_table_print_structure Message-ID: <20260310130819.41516-1-jayatheerthkulkarni2005@gmail.com> In-Reply-To: <4adf6d4dca90e2c7f780d594a533c21247c459b8.1773109018.git.gitgitgadget@gmail.com> > Remove the inner redeclaration since the outer 'entry' is already > available and non-NULL at that point. > > Signed-off-by: Mansi Singh > --- > builtin/repo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/builtin/repo.c b/builtin/repo.c > index 0ea045abc1..5540bd25d2 100644 > --- a/builtin/repo.c > +++ b/builtin/repo.c > @@ -412,7 +412,6 @@ static void stats_table_print_structure(const struct stats_table *table) > const char *unit = ""; > > if (entry) { > - struct stats_table_entry *entry = item->util; > value = entry->value; > if (entry->unit) > unit = entry->unit; > -- > gitgitgadget Hi Mansi, This is a good catch but I have to say this patch is already sent by me And is also merged into the master branch [1]. You can search in the mailing list or sometimes check the "What's cooking in git.git" (recent one [2]) before making the changes. You don't need anyone's permission to work on a patch but it is also important to not step on someone's toes ;) 1 - https://github.com/git/git/commit/676c145afdd88024057296f11fdf2c224001549e 2 - https://lore.kernel.org/git/xmqqh5qozdkq.fsf@gitster.g/T/#u coming to the double naming problem That is because one of your patch is using `format-patch` and `send-email` method of sending patches and the other one is using `gitgitgadget`. My suggestion would be to stick with one and move forward with that for the entirety. Regards, - Jayatheerth