From: K Jayatheerth Date: Wed, 04 Mar 2026 13:05:02 GMT Subject: [PATCH v2 3/3] path: remove redundant function calls Message-ID: <20260304130502.8475-4-jayatheerthkulkarni2005@gmail.com> In-Reply-To: <20260304130502.8475-1-jayatheerthkulkarni2005@gmail.com> repo_settings_get_shared_repository() is invoked multiple times in calc_shared_perm(). While the function internally caches the value, repeated calls still add unnecessary noise. Store the result in a local variable and reuse it instead. This makes it explicit that the value is expected to remain constant and avoids repeated calls in the same scope. Signed-off-by: K Jayatheerth --- path.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/path.c b/path.c index 56be5e1726..5cd38b2a16 100644 --- a/path.c +++ b/path.c @@ -741,18 +741,18 @@ int calc_shared_perm(struct repository *repo, int mode) { int tweak; - - if (repo_settings_get_shared_repository(repo) < 0) - tweak = -repo_settings_get_shared_repository(repo); + int shared_repo = repo_settings_get_shared_repository(repo); + if (shared_repo < 0) + tweak = -shared_repo; else - tweak = repo_settings_get_shared_repository(repo); + tweak = shared_repo; if (!(mode & S_IWUSR)) tweak &= ~0222; if (mode & S_IXUSR) /* Copy read bits to execute bits */ tweak |= (tweak & 0444) >> 2; - if (repo_settings_get_shared_repository(repo) < 0) + if (shared_repo < 0) mode = (mode & ~0777) | tweak; else mode |= tweak; -- 2.53.0