From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date: Sat, 28 Feb 2026 08:41:34 GMT
Subject: Re: [PATCH v3] send-email: validate charset name in 8bit encoding prompt
Message-ID: <20260228084217.239120-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To: <xmqq4in32ulj.fsf@gitster.g>

> Junio C Hamano <gitster@pobox.com> writes:
>
> > Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:
> >
> >> diff --git a/git-send-email.perl b/git-send-email.perl
> >> index cd4b316ddc..3230b80701 100755
> >> --- a/git-send-email.perl
> >> +++ b/git-send-email.perl
> >> @@ -23,6 +23,7 @@
> >>  use Git::LoadCPAN::Error qw(:try);
> >>  use Git;
> >>  use Git::I18N;
> >> +use Encode qw(find_encoding);
> >
> > I wonder how common is this module already installed on users'
> > systems (not asking "how widely available"---which is "can users
> > easily make it work?", but asking "would this work out of box with
> > what users already have?").
>
> Answering my own question: "yes".
>
> We use Encode::find_encoding as well as Encode::{de,en}code in
> gitweb and git-svn, so it is very likely that anybody who has a full
> installation of Git would already have it on their system.  Also
> Encode.pm is distributed as part of Perl itself, if I am not
> mistaken.

That's right, Encode is bundled with Perl, so users do not need to
install anything extra, other than what is already required for
building Git.