From: Patrick Steinhardt Date: Thu, 12 Feb 2026 06:59:36 GMT Subject: [PATCH v2 0/5] Small fixups for `OBJECT_INFO` flags Message-ID: <20260212-b4-pks-read-object-info-flags-v2-0-3bfa9bb149ef@pks.im> In-Reply-To: <20260126-b4-pks-read-object-info-flags-v1-0-e682a003b17c@pks.im> Hi, I was kind of curious why there were gaps in the `OBJECT_INFO_*` flags, but eventually found out that these gaps are of historic nature: there used to be more flags, but their respective values got removed at one point in time. So naturally, I wanted to clean this up a bit so that the next reader wouldn't have the same question. Surprisingly though I found out that this breaks tests, which of course puzzled me. As it turns out though, we were incorrectly using a couple of these flags for `odb_has_object()`, and the changed definitions had overlap with the existing meaning of other `HAS_OBJECT_*` flags. There isn't really any bug here as far as I can see, but this is only really by chance. In any case, the first two commits fix calls to `odb_has_object()` that used invalid flags. The last commit then removes the gaps and converts the flags to use an enum instead. Changes in v2: - Add two patches on top that convert the object info and `odb_has_object()` flags into enums. - Link to v1: https://lore.kernel.org/r/20260126-b4-pks-read-object-info-flags-v1-0-e682a003b17c@pks.im Thanks! Patrick --- Patrick Steinhardt (5): builtin/backfill: fix flags passed to `odb_has_object()` builtin/fsck: fix flags passed to `odb_has_object()` odb: drop gaps in object info flag values odb: convert object info flags into an enum odb: convert `odb_has_object()` flags into an enum builtin/backfill.c | 3 +-- builtin/fsck.c | 3 ++- object-file.c | 3 ++- object-file.h | 3 ++- odb.c | 4 ++-- odb.h | 44 +++++++++++++++++++++++++------------------- packfile.c | 2 +- packfile.h | 2 +- 8 files changed, 36 insertions(+), 28 deletions(-) Range-diff versus v1: 1: eec721a55b = 1: 308963f244 builtin/backfill: fix flags passed to `odb_has_object()` 2: 317893853b = 2: 7a69a648bb builtin/fsck: fix flags passed to `odb_has_object()` 3: c785043a72 < -: ---------- odb: drop gaps in object info flag values -: ---------- > 3: 0cea7f03f3 odb: drop gaps in object info flag values -: ---------- > 4: ab98547370 odb: convert object info flags into an enum -: ---------- > 5: 414dd30e14 odb: convert `odb_has_object()` flags into an enum --- base-commit: ea24e2c55433012a0a6c4ae947a87bc66404e484 change-id: 20260126-b4-pks-read-object-info-flags-236c4437cfc5