From: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Date: Wed, 04 Feb 2026 11:22:22 GMT
Subject: Re: [PATCH 3/3] wt-status: use hash_algo from local repository instead of global the_hash_algo
Message-ID: <20260204112304.72727-1-shreyanshpaliwalcmsmn@gmail.com>
In-Reply-To: <CAOLa=ZS3MHhHQrD3yJfZYfaO_FRdjcXQ-G-A+tF4=e6xmABjow@mail.gmail.com>

> > We cannot remove `USE_THE_REPOSITORY_VARIABLE` yet, because the changes done only
> > remove the direct use of the_hash_algo and the_repository,
> > but 'USE_THE_REPOSITORY_VARIABLE' is for all the global variables
> > that are still in use.
> >
> > In particular wt-status.c still relies on the following globals,
> >
> > * core_apply_sparse_checkout, this is already being addressed in an
> > ongoing patch series [1], so I intentionally did not modify it.
> >
> > * comment_line_str and DEFAULT_ABBREV, these both still are used in
> > wt-status.c but they dont have any local instance in wt-status.c,
> > or in any other form.
> >
> 
> Understandable.
> 
> > Removing these would require a wider refactoring (adding in struct wt_status,
> > adding helper functions etc) and I believe is better handled as a separate patch series.
> >
> 
> Yeah, my intent wasn't to have all the cleanup done in this series, but
> rather to ensure we have enough information presented. You've already
> explained the reason. It would be great if you could add this
> information to the cover.

Yes sure, I will add in v2.

> > Though I require some guidance on the preferred approach for handling
> > comment_line_str and DEFAULT_ABBREV going forward.
> >
> 
> Happy to help out. Generally using an RFC patch series generally has the
> best outcome, since it provides material to base discussions on.

Thanks, I will try to send an RFC patch series regarding this after the v2.

Best,
Shreyansh