From: Jeff King <peff@peff.net>
Date: Sat, 15 Nov 2025 01:53:10 GMT
Subject: Re: [PATCH] object-file: disallow adding submodules of different hash algo
Message-ID: <20251115015310.GA3499607@coredump.intra.peff.net>
In-Reply-To: <aRe6l5YRCzLAxeuB@fruit.crustytoothpaste.net>

On Fri, Nov 14, 2025 at 11:26:15PM +0000, brian m. carlson wrote:

> On 2025-11-13 at 16:29:00, Junio C Hamano wrote:
> > Jeff King <peff@peff.net> writes:
> > 
> > > So this is what I'd propose on top of your patch. I can hold onto it for
> > > later if we don't want to muddy up what you're trying to do.
> > 
> > I do agree with both of the above.  The patch below makes perfect
> > sense to me, and it is more about the quality of implementation of
> > this codepath in general, than the primary theme of Brian's changes,
> > so there is no strong reason they have to come in a single series.
> 
> That's certainly true, but it still applies cleanly on top of my revised
> patch and I'll just include it in v2.  I'm running tests now and should
> send out the series later tonight.

Thanks, your v2 looks great to me!

-Peff