From: Patrick Steinhardt Date: Tue, 21 Oct 2025 14:15:51 GMT Subject: [PATCH v5 03/12] replay: stop using `the_repository` Message-ID: <20251021-b4-pks-history-builtin-v5-3-78d23f578fe6@pks.im> In-Reply-To: <20251021-b4-pks-history-builtin-v5-0-78d23f578fe6@pks.im> In `create_commit()` we're using `the_repository` even though we already have a repository passed to use as an argument. Fix this. Note that we still cannot get rid of `USE_THE_REPOSITORY_VARIABLE`. This is because we use `DEFAULT_ABBREV and `get_commit_output_encoding()`, both of which are stored as global variables that can be modified via the Git configuration. Signed-off-by: Patrick Steinhardt --- replay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/replay.c b/replay.c index e22ce399406..13d75d80543 100644 --- a/replay.c +++ b/replay.c @@ -62,7 +62,7 @@ static struct commit *create_commit(struct repository *repo, obj = parse_object(repo, &ret); out: - repo_unuse_commit_buffer(the_repository, based_on, message); + repo_unuse_commit_buffer(repo, based_on, message); free_commit_extra_headers(extra); free_commit_list(parents); strbuf_release(&msg); -- 2.51.1.851.g4ebd6896fd.dirty