From: Adrian Ratiu Date: Fri, 17 Oct 2025 14:15:42 GMT Subject: [PATCH v2 08/10] hooks: allow callers to capture output Message-ID: <20251017141544.1538542-9-adrian.ratiu@collabora.com> In-Reply-To: <20251017141544.1538542-1-adrian.ratiu@collabora.com> From: Emily Shaffer Some server-side hooks will require capturing output to send over sideband instead of printing directly to stderr. Expose that capability. Signed-off-by: Emily Shaffer Signed-off-by: Ævar Arnfjörð Bjarmason --- hook.c | 1 + hook.h | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/hook.c b/hook.c index a325c7cb8c..fb452b5369 100644 --- a/hook.c +++ b/hook.c @@ -152,6 +152,7 @@ int run_hooks_opt(struct repository *r, const char *hook_name, .get_next_task = pick_next_hook, .start_failure = notify_start_failure, .feed_pipe = options->feed_pipe, + .consume_sideband = options->consume_sideband, .task_finished = notify_hook_finished, .data = &cb_data, diff --git a/hook.h b/hook.h index 82b3d1dd27..a84e97db34 100644 --- a/hook.h +++ b/hook.h @@ -65,6 +65,14 @@ struct run_hooks_opt * Only useful when using run_hooks_opt.feed_pipe, otherwise ignore it. */ void *feed_pipe_cb_data; + + /* + * Populate this to capture output and prevent it from being printed to + * stderr. This will be passed directly through to + * run_command:run_parallel_processes(). See t/helper/test-run-command.c + * for an example. + */ + consume_sideband_fn consume_sideband; }; #define RUN_HOOKS_OPT_INIT { \ -- 2.49.1