From: Patrick Steinhardt Date: Wed, 15 Oct 2025 06:04:08 GMT Subject: [PATCH v3 4/6] ci: check for common Rust mistakes via Clippy Message-ID: <20251015-b4-pks-ci-rust-v3-4-13810af33bd5@pks.im> In-Reply-To: <20251015-b4-pks-ci-rust-v3-0-13810af33bd5@pks.im> Introduce a CI check that uses Clippy to perform checks for common mistakes and suggested code improvements. Clippy is the official static analyser of the Rust project and thus the de-facto standard. Signed-off-by: Patrick Steinhardt --- ci/install-dependencies.sh | 2 +- ci/run-rust-checks.sh | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh index a24b07edff..dcd22ddd95 100755 --- a/ci/install-dependencies.sh +++ b/ci/install-dependencies.sh @@ -129,7 +129,7 @@ StaticAnalysis) RustAnalysis) sudo apt-get -q -y install rustup rustup default stable - rustup component add rustfmt + rustup component add clippy rustfmt ;; sparse) sudo apt-get -q -y install libssl-dev libcurl4-openssl-dev \ diff --git a/ci/run-rust-checks.sh b/ci/run-rust-checks.sh index 082eb52f11..fb5ea8991b 100755 --- a/ci/run-rust-checks.sh +++ b/ci/run-rust-checks.sh @@ -9,4 +9,9 @@ then RET=1 fi +if ! group "Check for common Rust mistakes" cargo clippy --all-targets --all-features -- -Dwarnings +then + RET=1 +fi + exit $RET -- 2.51.0.869.ge66316f041.dirty