From: Jeff King Date: Sat, 20 Sep 2025 18:46:38 GMT Subject: Re: [PATCH v3 01/10] xdiff: delete static forward declarations in xprepare Message-ID: <20250920184638.GA1010995@coredump.intra.peff.net> In-Reply-To: <83F61517-06DB-402E-911A-E33EE07D54AE@gmail.com> On Sat, Sep 20, 2025 at 01:46:19PM -0400, Ben Knoble wrote: > >> Best-viewed-with: --color-moved > > > > Two comments. > > > > - This is a bit unusual to see in the trailer. > > This was (loosely!) my suggestion, and I think Peff has once or twice > done something similar. I don't think I've ever used a trailer like that, but I do sometimes mention it in prose. I'll sometimes put it in comments below the "---" line, though. -Peff PS I sometimes find: git log --format='%(trailers:only,keyonly)' | sort | uniq -c | sort -rn amusing to look through for this sort of thing.