From: Jeff King <peff@peff.net>
Date: Sat, 02 Aug 2025 08:55:13 GMT
Subject: Re: [PATCH v2 05/11] merge-tree: do not use strbuf_split*()
Message-ID: <20250802085513.GD3711639@coredump.intra.peff.net>
In-Reply-To: <20250731225433.4028872-6-gitster@pobox.com>

On Thu, Jul 31, 2025 at 03:54:27PM -0700, Junio C Hamano wrote:

> -			if (input_merge_base && split[2] && split[3] && !split[4]) {
> [...]
> +			if (input_merge_base && split.nr == 4) {

I always hated strbuf_split() because the array-of-strbufs was awkward
to work with. But I never realized how inconvenient it was not to have
the count of split items until seeing that monstrosity in the pre-image. ;)

-Peff