From: Jeff King Date: Wed, 23 Jul 2025 23:59:29 GMT Subject: Re: [PATCH v3 2/2] t/helper/test-delta: fix possible resource leak and ensure safe cleanup Message-ID: <20250723235929.GB592873@coredump.intra.peff.net> In-Reply-To: <20250723080639.GA570920@coredump.intra.peff.net> On Wed, Jul 23, 2025 at 04:06:39AM -0400, Jeff King wrote: > On Wed, Jul 23, 2025 at 03:55:13AM -0400, Jeff King wrote: > > > I dunno. We are reaching diminishing returns spending brainpower on a > > function that is meant to be somewhat quick-and-dirty. > > OK, I clearly could not resist spending more brainpower on it. If we are > doing quick-and-dirty, why not just die()? The end result is the same, > but per my argument in the earlier iteration of the series, that means > we do not have to worry about cleaning up at all. So...I feel a little bad about hijacking Hoyoung's thread. But after all of the discussion, it seemed simplest to just stick it all into patches. So here is a potential replacement for patch 2. [1/3]: test-delta: handle errors with die() [2/3]: test-delta: use strbufs to hold input files [3/3]: test-delta: close output descriptor after use t/helper/test-delta.c | 77 ++++++++++++++----------------------------- 1 file changed, 24 insertions(+), 53 deletions(-) -Peff