From: Jeff King <peff@peff.net>
Date: Tue, 22 Jul 2025 23:10:19 GMT
Subject: Re: [PATCH v3] reflog: close leak of reflog expire entry
Message-ID: <20250722231019.GA1598@coredump.intra.peff.net>
In-Reply-To: <xmqqms8wuxkf.fsf@gitster.g>

On Tue, Jul 22, 2025 at 07:09:20AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > Subject: [PATCH] t1410: add test of gc.<pattern>.reflogExpire config
> >
> > We have long supported the ability to set reflog expiration config for
> > individual, going back to 3cb22b8efe (Per-ref reflog expiry
> > configuration, 2008-06-15). But we have never had any tests.
> 
> Yikes.  I completely forgot adding that feature, but it seems I also
> forgot to add tests when I added it.  My bad.
> 
> "individual" -> "individual refs" or something?  I was confused
> after my initial read, which sounded as if we are talking about
> allowing individual users to set the configuration variable ;-)

Yep, exactly. I admit I didn't spend as much time on the commit message
for this one, since I figured it might just get squashed anyway. :)

-Peff