From: Raymond E. Pasco Date: Sat, 28 Jun 2025 22:52:03 GMT Subject: [PATCH 1/5] apply: error on --intent-to-add outside gitdir Message-ID: <20250628225819.1294068-3-ray@ameretat.dev> In-Reply-To: <20250628225819.1294068-2-ray@ameretat.dev> It makes no sense to register an intent to add outside a repository. We should error out here. Based-on-patch-by: Johannes Altmanninger Signed-off-by: Raymond E. Pasco --- apply.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apply.c b/apply.c index 8bbe6ed224..e7856ae6b3 100644 --- a/apply.c +++ b/apply.c @@ -174,8 +174,12 @@ int check_apply_state(struct apply_state *state, int force_apply) return error(_("'%s' outside a repository"), "--cached"); state->check_index = 1; } - if (state->ita_only && (state->check_index || is_not_gitdir)) - state->ita_only = 0; + if (state->ita_only) { + if (is_not_gitdir) + return error(_("'%s' outside a repository"), "--intent-to-add"); + if (state->check_index) + state->ita_only = 0; + } if (state->check_index) state->unsafe_paths = 0; -- 2.50.0.195.g74e6fc65d0