From: Jeff King <peff@peff.net>
Date: Tue, 18 Mar 2025 00:20:12 GMT
Subject: Re: [PATCH v3 2/3] git-compat-util: add NOT_CONSTANT macro and use it in atfork_prepare()
Message-ID: <20250318002012.GB1470172@coredump.intra.peff.net>
In-Reply-To: <20250317235329.809302-3-gitster@pobox.com>

On Mon, Mar 17, 2025 at 04:53:28PM -0700, Junio C Hamano wrote:

> Introduce NOT_CONSTANT() macro, with which, the developer can tell
> the compiler:

This name looks great to me.

>  compiler-tricks/not-a-constant.c |  2 ++

And this is much better, too. ;) I see you dropped the "a" in the macro
name; I don't know if it matters much to do it here, too.

-Peff