From: Usman Akinyemi Date: Wed, 19 Feb 2025 20:32:50 GMT Subject: [PATCH v2 02/12] builtin/verify-tag: stop using `the_repository` Message-ID: <20250219203349.787173-3-usmanakinyemi202@gmail.com> In-Reply-To: <20250219203349.787173-1-usmanakinyemi202@gmail.com> Remove the_repository global variable in favor of the repository argument that gets passed in "builtin/verify-tag.c". When `-h` is passed to the command outside a Git repository, the `run_builtin()` will call the `cmd_verify_tag()` function with `repo` set to NULL and then early in the function, `parse_options()` call will give the options help and exit, without having to consult much of the configuration file. Mentored-by: Christian Couder Signed-off-by: Usman Akinyemi --- builtin/verify-tag.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c index f0e7c2a2b5..0acdb364dd 100644 --- a/builtin/verify-tag.c +++ b/builtin/verify-tag.c @@ -5,7 +5,6 @@ * * Based on git-verify-tag.sh */ -#define USE_THE_REPOSITORY_VARIABLE #include "builtin.h" #include "config.h" #include "gettext.h" @@ -23,7 +22,7 @@ static const char * const verify_tag_usage[] = { int cmd_verify_tag(int argc, const char **argv, const char *prefix, - struct repository *repo UNUSED) + struct repository *repo) { int i = 1, verbose = 0, had_error = 0; unsigned flags = 0; @@ -50,13 +49,13 @@ int cmd_verify_tag(int argc, flags |= GPG_VERIFY_OMIT_STATUS; } - git_config(git_default_config, NULL); + repo_config(repo, git_default_config, NULL); while (i < argc) { struct object_id oid; const char *name = argv[i++]; - if (repo_get_oid(the_repository, name, &oid)) { + if (repo_get_oid(repo, name, &oid)) { had_error = !!error("tag '%s' not found.", name); continue; } -- 2.48.1