From: Christian Couder Date: Mon, 27 Jan 2025 15:16:56 GMT Subject: [PATCH v4 1/6] version: replace manual ASCII checks with isprint() for clarity Message-ID: <20250127151701.2321341-2-christian.couder@gmail.com> In-Reply-To: <20250127151701.2321341-1-christian.couder@gmail.com> From: Usman Akinyemi Since the isprint() function checks for printable characters, let's replace the existing hardcoded ASCII checks with it. However, since the original checks also handled spaces, we need to account for spaces explicitly in the new check. Mentored-by: Christian Couder Signed-off-by: Usman Akinyemi --- version.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/version.c b/version.c index 4786c4e0a5..c9192a5beb 100644 --- a/version.c +++ b/version.c @@ -1,6 +1,7 @@ #include "git-compat-util.h" #include "version.h" #include "strbuf.h" +#include "sane-ctype.h" #ifndef GIT_VERSION_H # include "version-def.h" @@ -34,7 +35,7 @@ const char *git_user_agent_sanitized(void) strbuf_addstr(&buf, git_user_agent()); strbuf_trim(&buf); for (size_t i = 0; i < buf.len; i++) { - if (buf.buf[i] <= 32 || buf.buf[i] >= 127) + if (!isprint(buf.buf[i]) || buf.buf[i] == ' ') buf.buf[i] = '.'; } agent = buf.buf; -- 2.46.0.rc0.95.gcbf174a634