From: Jeff King Date: Fri, 03 Jan 2025 19:10:01 GMT Subject: Re: [PATCH 1/2] object-file: rename variables in `check_collision()` Message-ID: <20250103191001.GD3208749@coredump.intra.peff.net> In-Reply-To: <20250103-b4-pks-object-file-racy-collision-check-v1-1-6ef9e2da1f87@pks.im> On Fri, Jan 03, 2025 at 09:19:54AM +0100, Patrick Steinhardt wrote: > Rename variables used in `check_collision()` to clearly identify which > file is the source and which is the destination. This will make the next > step easier to reason about when we start to treat those files different > from one another. Seems obviously good, and definitely worth doing as a separate step from the actual code change. -Peff