From: Jeff King <peff@peff.net>
Date: Fri, 20 Dec 2024 08:53:37 GMT
Subject: Re: [PATCH] prio-queue: use size_t rather than int for size
Message-ID: <20241220085337.GA133148@coredump.intra.peff.net>
In-Reply-To: <20241220084949.GA132704@coredump.intra.peff.net>

On Fri, Dec 20, 2024 at 03:49:49AM -0500, Jeff King wrote:

> -static inline int compare(struct prio_queue *queue, int i, int j)
> +static inline int compare(struct prio_queue *queue, size_t i, size_t j)
>  {
>  	int cmp = queue->compare(queue->array[i].data, queue->array[j].data,
>  				 queue->cb_data);
>  	if (!cmp)
> -		cmp = queue->array[i].ctr - queue->array[j].ctr;
> +		cmp = (queue->array[i].ctr > queue->array[j].ctr) -
> +	              (queue->array[i].ctr < queue->array[j].ctr);
>  	return cmp;
>  }

Sorry, just realized that "diff --check" (and apply) complains about the
indentation here. It's a TAB followed by 14 spaces, instead of two TABs
followed by 6 spaces. I guess caused by me lining things up manually.

-Peff