From: Jeff King Date: Mon, 02 Dec 2024 20:37:43 GMT Subject: Re: [PATCH 1/4] refs: move ref name helpers around Message-ID: <20241202203743.GB776185@coredump.intra.peff.net> In-Reply-To: <20241202070714.3028549-2-gitster@pobox.com> On Mon, Dec 02, 2024 at 04:07:11PM +0900, Junio C Hamano wrote: > strbuf_branchname(), strbuf_check_{branch,tag}_ref() are helper > functions to deal with branch and tag names, and the fact that they > happen to use strbuf to hold the name of a branch or a tag is not > essential. These functions fit better in the refs API than strbuf > API, the latter of which is about string manipulations. Wow, they are declared in strbuf.h but not even implemented there. So it was doubly confusing. This looks like a nice cleanup. -Peff