From: Jeff King <peff@peff.net>
Date: Mon, 21 Oct 2024 19:03:09 GMT
Subject: Re: [PATCH v2] doc: document how uploadpack.allowAnySHA1InWant impact other allow options
Message-ID: <20241021190309.GC1219228@coredump.intra.peff.net>
In-Reply-To: <fd5fab45-1363-41c8-915a-5578a35d219d@gmail.com>

On Mon, Oct 21, 2024 at 07:55:06AM +0200, Piotr Szlazak wrote:

> On the second look code changes will be needed, as at the moment final
> result will differ between:
> [uploadpack]
>         allowTipSHA1InWant = true
>         allowReachableSHA1InWant = true
>         allowAnySHAInWant = false
> 
> and:
> 
> [uploadpack]
>         allowAnySHAInWant = false
>         allowTipSHA1InWant = true
>         allowReachableSHA1InWant = true

I'd expect them to differ. The config is read in order with a "last one
wins" rule. The thing that the documentation should be making clear is
that the three overlap in what they are affecting, and so "last one" is
not just a single key, but these three inter-related keys.

-Peff