From: Jeff King <peff@peff.net>
Date: Wed, 02 Oct 2024 22:01:18 GMT
Subject: Re: [PATCH] Fix unused-parameter warnings with NO_ICONV
Message-ID: <20241002220118.GA2892418@coredump.intra.peff.net>
In-Reply-To: <20241002200140.2123584-1-mh@glandium.org>

On Thu, Oct 03, 2024 at 05:01:40AM +0900, Mike Hommey wrote:

> The jk/unused-parameters topic enabled -Wunused-parameter. Some code in
> some non-typical configuration lacked annotations.

Thanks, this looks good. I tried to catch compile-time variants like
this, but I was mostly limited to what we build in CI.

Out of curiosity, what platform do you use that needs NO_ICONV (or is it
just a preference)?

-Peff