From: Jeff King Date: Mon, 09 Sep 2024 07:08:36 GMT Subject: Re: [PATCH] config.mak.uname: add HAVE_DEV_TTY to cygwin config section Message-ID: <20240909070836.GA4050065@coredump.intra.peff.net> In-Reply-To: On Mon, Sep 09, 2024 at 02:23:48AM +0100, Ramsay Jones wrote: > After more testing, I removed the RFC from this patch and actually wrote > a commit message. (I wasn't sure if I should mark this with v2 as well?). > > I was a bit surprised that this went unnoticed for so long, but I don't > use 'git credential' (shh-agent is all I need), 'git add -p' (vim works > for me!) or used the help.autocorrect=prompt. I have used 'git bisect' > many, many times (of course), but I don't recall ever seeing either of > those prompts! This goes for Linux as well as cygwin. :) The patch unsurprisingly looks good to me. I think most of what you are describing in the commit message is all the normal and expected benefits of HAVE_DEV_TTY. :) But I don't mind erring on the side of over-explaining there. -Peff