From: Jeff King Date: Sat, 17 Aug 2024 10:38:22 GMT Subject: Re: [PATCH 7/8] pseudo-merge.c: do not generate empty pseudo-merge commits Message-ID: <20240817103822.GC551779@coredump.intra.peff.net> In-Reply-To: On Thu, Aug 15, 2024 at 01:31:17PM -0400, Taylor Blau wrote: > The previous commit demonstrated it is possible to generate empty > pseudo-merge commits, which is not useful as such pseudo-merges carry no > information. > > Ensure that we only generate non-empty groups by not pushing a new > commit onto the bitmap_writer when that commit has no parents. Makes sense, and the patch seems pretty straight-forward. It's a little tempting to suggest that we keep some way of writing these, so that we can exercise the reading side in the tests (we _shouldn't_ see these if we're not writing them, but as an on-disk format, we may see examples from other sources). But it is probably not worth the complexity. If we really want to test them, we can probably generate a single example by hand (and we can probably even wait on that until we see something in the wild that makes it worth doing). -Peff