From: Jeff King <peff@peff.net>
Date: Thu, 01 Aug 2024 10:29:06 GMT
Subject: Re: [PATCH v2 14/19] midx: teach `midx_fanout_add_midx_fanout()` about incremental MIDXs
Message-ID: <20240801102906.GN1159276@coredump.intra.peff.net>
In-Reply-To: <594386da10bc3f3d6364916201438bf453b70098.1721250704.git.me@ttaylorr.com>

On Wed, Jul 17, 2024 at 05:12:38PM -0400, Taylor Blau wrote:

> The function `midx_fanout_add_midx_fanout()` is used to help construct
> the fanout table when generating a MIDX by reusing data from an existing
> MIDX.

I'm not sure I understand the original function enough to know if we're
doing the right thing. But I notice that after your series, we can only
get into midx_fanout_add_midx_fanout() if !ctx->incremental. So is this
code even used for an incremental midx?

Or is it used if we are writing a non-incremental midx, but trying to
reuse data from a chained one?

-Peff