From: Jeff King Date: Thu, 01 Aug 2024 10:07:46 GMT Subject: Re: [PATCH v2 08/19] midx: teach `bsearch_midx()` about incremental MIDXs Message-ID: <20240801100746.GH1159276@coredump.intra.peff.net> In-Reply-To: <38bd45bd24436d3404b089dff5c3d85f4026da97.1721250704.git.me@ttaylorr.com> On Wed, Jul 17, 2024 at 05:12:19PM -0400, Taylor Blau wrote: > Now that the special cases callers of `bsearch_midx()` have been dealt > with, teach `bsearch_midx()` to handle incremental MIDX chains. > > The incremental MIDX-aware version of `bsearch_midx()` works by > repeatedly searching for a given OID in each layer along the > `->base_midx` pointer, stopping either when an exact match is found, or > the end of the chain is reached. OK. I think this could have just happened in the last patch, but no big deal either way. -Peff