From: Jeff King <peff@peff.net>
Date: Mon, 08 Jul 2024 08:52:32 GMT
Subject: Re: [PATCH v4] doc: fix the max number of git show-branches shown
Message-ID: <20240708085232.GA819836@coredump.intra.peff.net>
In-Reply-To: <pull.1757.v4.git.1720319311301.gitgitgadget@gmail.com>

On Sun, Jul 07, 2024 at 02:28:31AM +0000, Rikita Ishikawa via GitGitGadget wrote:

> From: Rikita Ishikawa <lagrange.resolvent@gmail.com>
> 
> The number to be displayed is calculated by the
> following defined in object.h.
> 
> ```
>   #define REV_SHIFT        2
>   #define MAX_REVS        (FLAG_BITS - REV_SHIFT)
> ```
> 
> FLAG_BITS is currently 28, so 26 is the correct
> number.
> 
> Signed-off-by: Rikita Ishikawa <lagrange.resolvent@gmail.com>
> ---

Thanks, this version looks pretty good to me.

One minor nit: commit messages are not actually markdown (even when
rendered on GitHub), so your ``` block delimiters are a bit unusual.
We'd usually just rely on the indentation and blank lines to show the
structure.

-Peff