From: Jeff King <peff@peff.net>
Date: Sat, 06 Jul 2024 06:09:51 GMT
Subject: Re: [PATCH 2/3] t/chainlint: add test_expect_success call to test snippets
Message-ID: <20240706060951.GA700433@coredump.intra.peff.net>
In-Reply-To: <20240706060639.GB700151@coredump.intra.peff.net>

On Sat, Jul 06, 2024 at 02:06:39AM -0400, Jeff King wrote:

> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -109,9 +109,7 @@ clean-chainlint:
>  check-chainlint:
>  	@mkdir -p '$(CHAINLINTTMP_SQ)' && \
>  	for i in $(CHAINLINTTESTS); do \
> -		echo "test_expect_success '$$i' '" && \
> -		sed -e '/^# LINT: /d' chainlint/$$i.test && \
> -		echo "'"; \
> +		sed -e '/^# LINT: /d' chainlint/$$i.test; \
>  	done >'$(CHAINLINTTMP_SQ)'/tests && \
>  	{ \
>  		echo "# chainlint: $(CHAINLINTTMP_SQ)/tests" && \

BTW, not new in my patch, but I found it ironic that the shell snippet
here itself violates &&-chain rules. It should "|| exit 1" inside the
loop if a sed call fails.

-Peff