From: Jeff King <peff@peff.net>
Date: Sat, 08 Jun 2024 11:32:31 GMT
Subject: Re: [PATCH v3] credential: clear expired c->credential, unify secret clearing
Message-ID: <20240608113231.GD2966571@coredump.intra.peff.net>
In-Reply-To: <20240606183516.4077896-2-aplattner@nvidia.com>

On Thu, Jun 06, 2024 at 11:35:16AM -0700, Aaron Plattner wrote:

> v3: I reverted the behavior change to credential_reject() and just unified
> everything to use credential_clear_secrets() instead. We can rework
> credential_reject() in a later change if we decide to. So the only behavior
> change now should be the expiration case in credential_fill()
> 
> I also updated some of the comments in credential.h to mention the new struct
> fields.

Thanks, this one looks great to me.

> Thanks for your patience with this series, everyone!

Likewise!

-Peff